Make replication flush interval configurable in mysql source #202
Conversation
saurabhojha
force-pushed
the
saurabh/transfer/configure-flush-intervals
branch
from
8b64ab2 to
c9109c2
Compare
saurabhojha
force-pushed
the
saurabh/transfer/configure-flush-intervals
branch
from
c9109c2 to
178fab7
Compare
|
@laskoviymishka has imported your pull request. If you are a member of Transfer team, you can view this diff. |
| - **ReplicationFlushInterval** (`time.Duration`): Specifies the replication flush interval. Defined in nanoseconds. | ||
| - Example: `5000000000` (5 seconds) |
There was a problem hiding this comment.
Let's change it to milliseconds (1/1000 of second). I don't see a case when user will need to specify interval with such accuracy
There was a problem hiding this comment.
see: #215
this would allow to type 5s instead of 5000000000
There was a problem hiding this comment.
Migrating to yaml.v3 wouldn't solve this issue. Since we first convert yaml configuration to a TransferYamlView which parses entire config as any type. Converting from json (done later in NewSource and NewDestination methods) to the desired config struct again would raise the following error:
unable to construct missed fields: failed to decode: 1 error(s) decoding:
- 'ReplicationFlushInterval' expected type 'time.Duration', got unconvertible type 'string', value: '5s'
|
✅ This pull request is being closed because it has been successfully merged into our internal monorepository. |
Add a replication flush interval in mysql source config.
This pr closes : #59